Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default engine changes for #513 #515

Merged
merged 4 commits into from Jun 24, 2021
Merged

default engine changes for #513 #515

merged 4 commits into from Jun 24, 2021

Conversation

topepo
Copy link
Member

@topepo topepo commented Jun 15, 2021

Each model now has a default engine that is used when the model is defined. The default for each model is listed in the help documents.

This also adds functionality to change to declare an engine in the model specification function.

set_engine() is still required if engine-specific arguments need to be added

NEWS.md Outdated Show resolved Hide resolved
topepo and others added 2 commits June 17, 2021 12:58
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
@juliasilge
Copy link
Member

This is a really nice change; I am super happy about it.

I just made a few edits to how we describe mode and engine so they are more consistent and more in line with how we talk about them elsewhere, like here and here. For example, I don't think we should use the word "type" for either of those since we use it for the algorithm choice.

@juliasilge
Copy link
Member

I can't imagine there will be any problems but have any of us run extratests with this PR built?

@topepo
Copy link
Member Author

topepo commented Jun 24, 2021

I can't imagine there will be any problems but have any of us run extratests with this PR built?

[ FAIL 0 | WARN 0 | SKIP 6 | PASS 252 ]

@topepo topepo merged commit ae16fb8 into master Jun 24, 2021
@juliasilge juliasilge deleted the add-default-engine branch June 24, 2021 21:40
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants