switch to cli in various functions #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilHvitfeldt
commented
Oct 13, 2023
Comment on lines
+273
to
+277
| cli::cli_abort( | ||
| c( | ||
| "!" = "Please supply at least one variable specification.", | ||
| "i" = "See {.help [?selections](recipes::selections)} \\ | ||
| for more information." |
There was a problem hiding this comment.
I didn't add tests for this, as it is technically deprecated. I opened an issue to properly handle that here #1243
EmilHvitfeldt
commented
Oct 13, 2023
| "the data passed using `training` will be ", | ||
| "ignored." | ||
| ) | ||
| if (!is.null(rec$template)) { |
There was a problem hiding this comment.
This was the bug that is mentioned in the PR. $training never worked.
Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
Merge commit '26a7ed8ddcffd9fefe5956b8d97d5a94a62f2778' #Conflicts: # NEWS.md
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1237
This PR is a little bitter since there was a couple of use-cases that didn't neatly fit anywhere else.
A bug was found, and fixed, which was about how retraining a recipe will ignore new data, this now throws a warning as intended