Fix for legacy recipes in bake.step_log() method
#1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- legacy recipes index the `columns` entry of `object` whereas newer recipes index `names(object$columns)` - this breaks backward compatibility - This bugfix prefers the 'new' syntax, but if `names(object)` is `NULL`, reverts to the 'old' syntax - fixes tidymodels#1284
|
Looking good! Thanks for the PR, I'll start working on a patch release first thing tomorrow |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible Bugfix
bake()edobjects in the newrecipessyntax.commit message:
columnsentry ofobjectwhereas newer recipes indexnames(object$columns)names(object)isNULL, reverts to the 'old' syntaxbake.step_log()S3 method breaks legacy recipe objects #1284