Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for legacy recipes in bake.step_log() method #1285

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Fix for legacy recipes in bake.step_log() method #1285

merged 3 commits into from
Feb 16, 2024

Commits on Feb 12, 2024

  1. Fix for legacy recipes in bake.step_log() method 

    - legacy recipes index the `columns` entry of `object`
  whereas newer recipes index `names(object$columns)`
- this breaks backward compatibility
- This bugfix prefers the 'new' syntax, but if
  `names(object)` is `NULL`, reverts to the 'old' syntax
- fixes tidymodels#1284
    @stufield
    stufield committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3e3408c View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merged origin/main into stufield-bugfix-for-legacy-recipes-bake.step_log

    @EmilHvitfeldt
    EmilHvitfeldt committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    c202f94 View commit details
    Browse the repository at this point in the history

  2. add comment

    @EmilHvitfeldt
    EmilHvitfeldt committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    5839e82 View commit details
    Browse the repository at this point in the history