Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 3-way validation split interface #701

Merged
merged 7 commits into from Jul 27, 2023

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Jul 4, 2023

closes #697

This PR adds support for the new interface to validation sets in rsample via initial_validation_split() and validation_set().

As laid out in #697 (comment), this

  • extends last_fit() to work with objects coming from initial_validation_split()
  • adds an argument use_validation_set to last_fit() and fit_best()
  • sets defaults for use_validation_set so that we keep using the validation set for objects coming from the old interface but do not use it for objects from the new interface

To make that possible, rsample adds another attribute to validation rset objects coming from the new interface validation_set() in tidymodels/rsample#437

For reference, we will deprecate the old interface: tidymodels/rsample#350

@hfrick hfrick requested a review from topepo July 4, 2023 14:32
R/fit_best.R Outdated Show resolved Hide resolved
Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise great. I'll wait for the name changes from rsample to do anything with this.

R/last_fit.R Show resolved Hide resolved
@hfrick hfrick merged commit eaca118 into main Jul 27, 2023
9 checks passed
@hfrick hfrick deleted the val-split-final-fit-on-train-only branch July 27, 2023 12:20
@EmilHvitfeldt EmilHvitfeldt mentioned this pull request Jul 29, 2023
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support initial_validation_split objects
2 participants