Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .fit_finalize() in code paths #296

Merged
merged 7 commits into from Oct 7, 2020

Conversation

DavisVaughan
Copy link
Member

Closes #294

Now the workflows extracted from tune_grid(), tune_bayes(), and fit_resamples() are all "finalized". This propagates to last_fit() as well, which means that workflow can now be predicted from.

@DavisVaughan DavisVaughan merged commit 5b6ad36 into tidymodels:master Oct 7, 2020
@DavisVaughan DavisVaughan deleted the fix/fit-finalize branch October 7, 2020 19:21
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant