Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type argument to autoplot.workflowset() #134

Merged
merged 2 commits into from Jan 8, 2024
Merged

add type argument to autoplot.workflowset() #134

merged 2 commits into from Jan 8, 2024

Conversation

simonpcouch
Copy link
Contributor

Closes #114.

Unsure whether we should add an argument like this PR does or just change the default behavior. Also, I don't feel confident in the names of the argument values.馃

library(tidymodels)

mt_rec <- recipe(mpg ~ ., mtcars)
mt_rec2 <- mt_rec %>% step_normalize(all_numeric_predictors())
mt_rec3 <- mt_rec %>% step_YeoJohnson(all_numeric_predictors())

wflow_set <-
   workflow_set(list(mt_rec, mt_rec2, mt_rec3), list(linear_reg()))

set.seed(1)
wflow_set_fit <- 
   workflow_map(
      wflow_set, 
      "fit_resamples", 
      resamples = bootstraps(mtcars), 
      seed = 1
   )

autoplot(wflow_set_fit, type = "wflow_id")

Created on 2023-11-29 with reprex v2.0.2

@simonpcouch
Copy link
Contributor Author

No need to review for the nitty gritty until we feel that the overall approach is sound.

Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new type. But I don't have strong feelings about making it the default.

I wish documentation was better

Copy link
Member

@topepo topepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. No notes.

@simonpcouch simonpcouch merged commit 148e737 into main Jan 8, 2024
10 checks passed
@simonpcouch simonpcouch deleted the plot-114 branch January 8, 2024 18:33
@jrosell
Copy link

jrosell commented Jan 9, 2024

I really like the new type. But I don't have strong feelings about making it the default.

I wish documentation was better

IMHO, it could be a better default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More informative autoplot.workflowset
4 participants