-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End of 2nd day materials #62
Conversation
One more note: we are getting a loooooooot of |
There's a long thing in the annotations about the rank deficiency. We can solve it by adding the step for linear combination. I wouldn't do that right away in the notes but we can add it later to get rid of warnings. That shape makes a lot of sense. The x axis is going to give symmetric patterns Since it is the distance from centerline to each goal. It makes sense for shots to get higher probability of being on goal as you get closer to the 89 foot mark on either side. It should rapidly decrease after that because you are behind the goal. |
And defenders are more likely to have a shot be on goal when they take it? |
There are, in general, less likely to have a shot on goal since almost all of the other players are in front of them. |
I'm getting into the habit of only committing sources (qmd + new pre-made images) and rendering in main once merged. The number of files changes + conflicts are a pain. |
Closes #35 with a few more slides and an addition to
06-classwork.qmd
I have a couple of questions about how this turned out. Take a look at the coefficients:
Defense has a higher probability than the other positions. Is that right?
Here is the PDPs look:
![pdp](https://user-images.githubusercontent.com/12505835/180104187-07c6128e-fdc2-46d0-8a37-7341efdea2b3.png)
Notice the shape (this is with the splines -- ) and how the positions are arranged.
Should we be saying, like I did here, "Predicted probability of not being on goal" on the y-axis? Are the factor levels getting messed up at some point? Am I misunderstanding this somehow and this is all right, and I need to change to "Predicted probability of being on goal"?
Also, just for the record, these decks are not reproducible, I don't think (need more seeds?). This is more a note for later, but a lot changed when I rendered again in terms of xgboost results. I did not check in those lines with changes.