Track tasks and feature requests
Join 40 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprisesAdd support for new src/tbl class in DB simulations #111
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
@edgararuiz do you remember what this is about? |
This comment has been minimized.
This comment has been minimized.
Oh this is the problem: lf1 <- dbplyr::lazy_frame(x = 1:4, src = dbplyr::simulate_oracle())
class(lf1)
#> [1] "tbl_lazy" "tbl" Created on 2019-01-09 by the reprex package (v0.2.1.9000) |
This comment has been minimized.
This comment has been minimized.
Sorry, I totally missed your message from last week. Yes, that's the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@edgararuiz commented on May 24, 2018, 4:00 PM UTC:
Adding support in the
dbplyr::simulate_###()
functions of the new src/tbl class that is being passed in the dev version ofdbplyr
will allow us to adds test to the customizations (ref: tidyverse/dbplyr@81419ca)Using a PR's version of
dbplyr
, this should be usingMINUS
instead ofEXCEPT
:This issue was moved by krlmlr from tidyverse/dplyr/issues/3598.