Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new src/tbl class in DB simulations #111

Closed
move bot opened this issue Jun 25, 2018 · 3 comments
Closed

Add support for new src/tbl class in DB simulations #111

move bot opened this issue Jun 25, 2018 · 3 comments
Milestone

Comments

@move
Copy link

@move move bot commented Jun 25, 2018

@edgararuiz commented on May 24, 2018, 4:00 PM UTC:

Adding support in the dbplyr::simulate_###() functions of the new src/tbl class that is being passed in the dev version of dbplyr will allow us to adds test to the customizations (ref: tidyverse/dbplyr@81419ca)

Using a PR's version of dbplyr, this should be using MINUS instead of EXCEPT:

library(dplyr, warn.conflicts = FALSE)
packageVersion("dbplyr")
#> [1] '1.2.1.9001'
lf1 <- dbplyr::lazy_frame(x = 1:4, src = dbplyr::simulate_oracle())
lf2 <- dbplyr::lazy_frame(x = 1:4, src = dbplyr::simulate_oracle())
lf1 %>% setdiff(lf2) %>% show_query()
#> <SQL> (SELECT *
#> FROM `df`)
#> EXCEPT
#> (SELECT *
#> FROM `df`)

This issue was moved by krlmlr from tidyverse/dplyr/issues/3598.

@hadley

This comment has been minimized.

Copy link
Member

@hadley hadley commented Jan 2, 2019

@edgararuiz do you remember what this is about?

@hadley hadley added this to the v1.4.0 milestone Jan 9, 2019
@hadley

This comment has been minimized.

Copy link
Member

@hadley hadley commented Jan 10, 2019

Oh this is the problem:

lf1 <- dbplyr::lazy_frame(x = 1:4, src = dbplyr::simulate_oracle())
class(lf1)
#> [1] "tbl_lazy" "tbl"

Created on 2019-01-09 by the reprex package (v0.2.1.9000)

@edgararuiz

This comment has been minimized.

Copy link
Collaborator

@edgararuiz edgararuiz commented Jan 10, 2019

Sorry, I totally missed your message from last week. Yes, that's the issue

@hadley hadley closed this in 33203a5 Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.