Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new src/tbl class in DB simulations #3598

Closed
edgararuiz-zz opened this issue May 24, 2018 · 2 comments
Closed

Add support for new src/tbl class in DB simulations #3598

edgararuiz-zz opened this issue May 24, 2018 · 2 comments

Comments

@edgararuiz-zz
Copy link

Adding support in the dbplyr::simulate_###() functions of the new src/tbl class that is being passed in the dev version of dbplyr will allow us to adds test to the customizations (ref: tidyverse/dbplyr@81419ca)

Using a PR's version of dbplyr, this should be using MINUS instead of EXCEPT:

library(dplyr, warn.conflicts = FALSE)
packageVersion("dbplyr")
#> [1] '1.2.1.9001'
lf1 <- dbplyr::lazy_frame(x = 1:4, src = dbplyr::simulate_oracle())
lf2 <- dbplyr::lazy_frame(x = 1:4, src = dbplyr::simulate_oracle())
lf1 %>% setdiff(lf2) %>% show_query()
#> <SQL> (SELECT *
#> FROM `df`)
#> EXCEPT
#> (SELECT *
#> FROM `df`)
@ghost
Copy link

ghost commented Jun 25, 2018

This issue was moved by krlmlr to tidyverse/dbplyr/issues/111.

@ghost ghost closed this as completed Jun 25, 2018
@lock
Copy link

lock bot commented Dec 22, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Dec 22, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant