Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export <dbplyr_table_ident> tools #1300

Closed
mgirlich opened this issue Jun 13, 2023 · 0 comments · Fixed by #1458
Closed

Export <dbplyr_table_ident> tools #1300

mgirlich opened this issue Jun 13, 2023 · 0 comments · Fixed by #1458
Labels
feature a feature request or enhancement
Milestone
2.5.0

Comments

@mgirlich
Copy link
Collaborator

At least for the dm package this would be nice.
After we did this we might be able to get rid of the classes <dbplyr_catalog>, <dbplyr_schema()> and <ident_q> in the future. But its not easy to get rid of a class. Maybe we could do that by deprecating escape.dbplyr_schema/dbplyr_catalog/ident_q().
@mgirlich mgirlich added this to the 2.5.0 milestone Oct 27, 2023
@hadley hadley added the feature a feature request or enhancement label Nov 2, 2023
@hadley hadley modified the milestones: 2.5.0, 2.4.1 Feb 14, 2024
hadley added a commit that referenced this issue Feb 20, 2024
@hadley
Export table_path infrastructure
69839c3 
Fixes #1300

Includes some changes to make the interface a little nicer and to fix some issues I noticed while I was looking at this code with fresh eyes:

* `table_name()` -> `table_path_name()`
* `is_table_id()` requires characters and table_paths to be length 1
* Vectorise `table_path_components()` instead of `table_path_name()`
* Make `table_path_components()` an S3 generic (as an escape hatch if needed)
@hadley hadley mentioned this issue Feb 20, 2024
Merged
hadley added a commit that referenced this issue Feb 21, 2024
@hadley
Export table_path infrastructure (#1458)
5b07997 
Fixes #1300

Includes some changes to make the interface a little nicer and to fix some issues I noticed while I was looking at this code with fresh eyes:

* `table_name()` -> `table_path_name()`
* `is_table_id()` requires characters and table_paths to be length 1
* Vectorise `table_path_components()` instead of `table_path_name()`
* Make `table_path_components()` an S3 generic (as an escape hatch if needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Export table_path infrastructure tidyverse/dbplyr
2 participants
@hadley @mgirlich