Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rows_patch.tbl_lazy fails when patching more than one column #1443

Closed
gorcha opened this issue Jan 31, 2024 · 0 comments · Fixed by #1444
Closed

rows_patch.tbl_lazy fails when patching more than one column #1443

gorcha opened this issue Jan 31, 2024 · 0 comments · Fixed by #1444

Comments

@gorcha
Copy link
Member

gorcha commented Jan 31, 2024

The tbl_lazy version of rows_patch() throws an error if more than one column is to be updated.
There's a simple bug in the code that builds the coalesce calls, PR is incoming!

library(dplyr)
library(dbplyr)

rows_patch(
  memdb_frame(x = 1:3, y = c(11, 12, NA), z = c(31, NA, 33)),
  memdb_frame(x = 2:3, y = 22:23, z = 42:43),
  by = "x",
  unmatched = "ignore",
  in_place = FALSE
)
#> Error in `sym()`:
#> ! Can't convert a character vector to a symbol.

Created on 2024-01-31 with reprex v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant