Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse tibble::print.tbl() for printing #14
Conversation
This comment has been minimized.
This comment has been minimized.
Can you keep the extra spaces so the colons line up? |
|
||
# S3: tbl_dbi | ||
# A tibble : ?? x 5 | ||
# Source : table<iris-output-test> [?? x 5] |
This comment has been minimized.
This comment has been minimized.
krlmlr
May 14, 2017
Author
Member
Now aligning colons by adding space before them. Let me know if you prefer adding space after the colon, like in the original output.
This comment has been minimized.
This comment has been minimized.
|
||
# S3: tbl_dbi | ||
# A tibble : ?? x 5 | ||
# Source : table<iris-output-test> [?? x 5] |
This comment has been minimized.
This comment has been minimized.
krlmlr
May 14, 2017
Author
Member
Now aligning colons by adding space before them. Let me know if you prefer adding space after the colon, like in the original output.
Ordered by: Sepal.Length | ||
|
||
# S3: tbl_dbi | ||
# A tibble : ?? x 5 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hadley
commented on 267d7b7
May 15, 2017
Looks great! |
This comment has been minimized.
This comment has been minimized.
I don't have permission to merge. |
This comment has been minimized.
This comment has been minimized.
@krlmlr See tidyverse/tibble#285, |
krlmlr commentedMay 13, 2017
•
edited
now only need to override
tbl_sum()
. Also fixes tests.Closes tidyverse/dplyr#2749.
@hadley: Could you please review (and enable reviews for this repo)?