Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tibble::print.tbl() for printing #14

Merged
merged 4 commits into from
May 15, 2017

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented May 13, 2017

now only need to override tbl_sum(). Also fixes tests.

Closes tidyverse/dplyr#2749.

@hadley: Could you please review (and enable reviews for this repo)?

@hadley
Copy link
Member

hadley commented May 13, 2017

Can you keep the extra spaces so the colons line up?


# S3: tbl_dbi
# A tibble : ?? x 5
# Source : table<iris-output-test> [?? x 5]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now aligning colons by adding space before them. Let me know if you prefer adding space after the colon, like in the original output.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer space after colon


# S3: tbl_dbi
# A tibble : ?? x 5
# Source : table<iris-output-test> [?? x 5]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now aligning colons by adding space before them. Let me know if you prefer adding space after the colon, like in the original output.

Ordered by: Sepal.Length

# S3: tbl_dbi
# A tibble : ?? x 5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

@krlmlr
Copy link
Member Author

krlmlr commented May 15, 2017

I don't have permission to merge.

@hadley hadley merged commit edede07 into tidyverse:master May 15, 2017
@javierluraschi
Copy link
Contributor

@krlmlr See tidyverse/tibble#285, dplyr used to trigger tbl_desc() for computing the headers of a tibble, but now we rely on tibble itself, which is great; however, tibble calls nrow and dim which is subclassed in some backends to trigger a full table scan.

@krlmlr krlmlr deleted the f-#2749-print-tbl branch March 10, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement tbl_sum.tbl_sql()
3 participants