Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add paste and paste0 translation for ORACLE #221

Merged
merged 4 commits into from Jan 19, 2019

Conversation

cderv
Copy link
Contributor

@cderv cderv commented Jan 19, 2019

closes #155

Following these documentations:

translate paste and paste0 using the infix operator ||

@@ -20,3 +20,14 @@ test_that("queries translate correctly", {
sql("^SELECT [*] FROM [(]SELECT [*]\nFROM [(]`df`[)] [)] `[^`]*` WHERE ROWNUM [<][=] 6")
)
})

test_that("vectorised translations", {
Copy link
Member

@hadley hadley Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like slightly too much testing because you're effectively testing sql_paste_infix(), which should be tested elsewhere. I think a single "sanity" check for paste() and paste0() should be adequate.

@hadley hadley merged commit 720b4fb into tidyverse:master Jan 19, 2019
1 check was pending
@hadley
Copy link
Member

@hadley hadley commented Jan 19, 2019

Thank you!

@cderv cderv deleted the fix/155-paste-oracle branch Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants