Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow argument na.rm in median() #483

Merged
merged 4 commits into from
Sep 17, 2020
Merged

allow argument na.rm in median() #483

merged 4 commits into from
Sep 17, 2020

Conversation

lorenzwalthert
Copy link
Contributor

Closes #442 by extending the codebase as suggested there. Let's see if tests pass...

@lorenzwalthert lorenzwalthert mentioned this pull request Jul 4, 2020
Closed
@hadley
Copy link
Member

hadley commented Sep 17, 2020

Thanks! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@lorenzwalthert
Copy link
Contributor Author

Done.

@hadley hadley merged commit 6399664 into tidyverse:master Sep 17, 2020
@hadley
Copy link
Member

hadley commented Sep 17, 2020

Thanks!

@lorenzwalthert lorenzwalthert deleted the issue-442 branch December 21, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

na.rm argument in median() for consistency with stats::median()
2 participants
@lorenzwalthert @hadley