Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve construction and coercion of tbl_cube #1568

Merged
merged 3 commits into from Mar 1, 2016
Merged

Improve construction and coercion of tbl_cube #1568

merged 3 commits into from Mar 1, 2016

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 2, 2015

  • new argument met_name = guess_met() in as.tbl_cube.data.frame
    • all coercion methods generate identical cubes for the same data
  • properly handle incomplete cubes and duplication of dimensions

With tests.

Kirill Müller added 3 commits December 3, 2015 00:39
@krlmlr krlmlr mentioned this pull request Jan 14, 2016
Closed
@hadley hadley merged commit e879db7 into tidyverse:master Mar 1, 2016
@hadley
Copy link
Member

hadley commented Mar 1, 2016

Thanks!

@krlmlr krlmlr deleted the as.tbl_cube.data.frame branch March 1, 2016 21:47
@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krlmlr @hadley