Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_equal/equal_data_frame throws an error with list columns #2194

Closed
richierocks opened this issue Oct 23, 2016 · 2 comments
Closed

all_equal/equal_data_frame throws an error with list columns #2194

richierocks opened this issue Oct 23, 2016 · 2 comments

Comments

@richierocks
Copy link

Given two identical data_frames with a list column,

d1 <- d2 <- tibble::data_frame(x = list(1))

I expected all_equal to return TRUE. Instead, I got an error:

dplyr::all_equal(d1, d2)
## Error: Can't join on 'x' x 'x' because of incompatible types (list / list)

The problem appears to originate in the Rcpp code called from equal_data_frame.

@krlmlr
Copy link
Member

krlmlr commented Nov 7, 2016

When are two elements of a list column equal? For n_distinct(), it's reference equality (#2222); we could certainly implement this, but object equality is going to be difficult.

@hadley
Copy link
Member

hadley commented Feb 2, 2017

Now part of #2355

@hadley hadley closed this as completed Feb 2, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants