Allow one join suffix to be the empty string #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Feb 20, 2017
| // we suffix by .x if this column is in y_columns (and if the suffix is not empty) | ||
| if (suffix_x.length() > 0) { | ||
| while ( | ||
| (std::find(y_columns.begin(), y_columns.end(), col_name.get_sexp()) != y_columns.end()) || |
There was a problem hiding this comment.
This seems a bit complicated as a while condition
There was a problem hiding this comment.
Yes. There is also duplication with the R function unique_names(), ideally we'd have one C++ routine for creating column names. Can we merge as-is and postpone cleanup?
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids endless loop.
Fixes #2228.
@hadley: PTAL.