Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible solution for selecting translation for arbitrary connections #3160

Closed
hadley opened this issue Oct 23, 2017 · 3 comments
Closed

Flexible solution for selecting translation for arbitrary connections #3160

hadley opened this issue Oct 23, 2017 · 3 comments
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Oct 23, 2017

Need to verify which connection methods actually get used (I think just escaping, and the rest is just S3 dispatch) and then provide some lightweight way for users to select their own translation layer.

Maybe something like:

con <- custom_translation(jdbcConnection, "Oracle")

with arguments to override default quoting for identifiers and strings?

All methods would need to redispatch to wrapped object.

@hadley hadley added database feature a feature request or enhancement labels Oct 23, 2017
@hadley
Copy link
Member Author

hadley commented Oct 27, 2017

Alternatively could provide something like:

register_translation(class(con), "Oracle", identifier = "'", string = '"')

And have custom behaviour in sql_translate_env.default() that would call getS3method()

@ghost
Copy link

ghost commented Jun 8, 2018

This issue was moved by hadley to tidyverse/dbplyr/issues/98.

@ghost ghost closed this as completed Jun 8, 2018
@lock
Copy link

lock bot commented Dec 5, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Dec 5, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant