Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should by parameters of join functions support vars() specifications? #3965

Closed
lionel- opened this issue Nov 13, 2018 · 5 comments
Closed

Should by parameters of join functions support vars() specifications? #3965

lionel- opened this issue Nov 13, 2018 · 5 comments

Comments

@lionel-
Copy link
Member

lionel- commented Nov 13, 2018

Would allow things like:

left_join(df1, df2, by = vars(starts_with("s"))
full_join(df1, df2, by = vars(foo:bar)
@hadley
Copy link
Member

hadley commented Nov 13, 2018

I think we'll eventually also need something like mutate-like semantics (i.e. left.y < right.y) so we need to be a little careful about going down this route.

@romainfrancois
Copy link
Member

We could have .left$ and .right$ pronouns

@lionel-
Copy link
Member Author

lionel- commented Jan 6, 2019

mutate() semantics could be handled with a new acts() external quoter.

@krlmlr
Copy link
Member

krlmlr commented Feb 16, 2019

Related: #2240.

@hadley
Copy link
Member

hadley commented Dec 10, 2019

Closing in favour of linked issue

@hadley hadley closed this as completed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hadley @krlmlr @romainfrancois @lionel-