Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select not gets overruled #644

Closed
rgknight opened this issue Sep 29, 2014 · 2 comments
Closed

select not gets overruled #644

rgknight opened this issue Sep 29, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@rgknight
Copy link

@rgknight rgknight commented Sep 29, 2014

Per Hadley's comment on the manipulatr thread, select is supposed to return the first instance of a name mentioned, i.e.,

names( select(iris, starts_with("S"), sepal.wid = Sepal.Width))
[1] "Sepal.Length" "Sepal.Width"  "Species"  

is correct. However, when you use the not option, it gets overruled when additional conditions are specified, i.e.

> names( select(iris, -starts_with("P"), Sepal.Width))
[1] "Sepal.Width"

should return all names that don't start with P.

@hadley hadley added the bug label Sep 30, 2014
@hadley hadley added this to the 0.3.1 milestone Sep 30, 2014
@hadley hadley self-assigned this Sep 30, 2014
@hadley
Copy link
Member

@hadley hadley commented Nov 20, 2014

This now doesn't seem right to me - inclusion/exclusion should be applied from left-to-right, so that the last name should win

@hadley
Copy link
Member

@hadley hadley commented Nov 26, 2014

Closed in 713a15c etc

@hadley hadley closed this Nov 26, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants