Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

na_matches = "never" doesn't work if matching columns contain only NAs #6804

Closed
moodymudskipper opened this issue Mar 22, 2023 · 1 comment · Fixed by #6805
Closed

na_matches = "never" doesn't work if matching columns contain only NAs #6804

moodymudskipper opened this issue Mar 22, 2023 · 1 comment · Fixed by #6805

Comments

@moodymudskipper
Copy link

dplyr::inner_join(data.frame(a=NA), data.frame(a=NA), by = "a", na_matches = "never")
#> Error in `dplyr::inner_join()`:
#> ! Can't convert `out[merge]$a` <logical> to match type of `a` <vctrs_unspecified>.

Created on 2023-03-22 with reprex v2.0.2

@zajichek
Copy link

zajichek commented Jun 9, 2023

Any conversation on making na_matches = "never" the default argument? I wouldn't have expected that NA values would be joined by default, but maybe that's just me. Anyway, just wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants