starwars data - Replace defunct API
#6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
reviewed
Nov 3, 2023
There was a problem hiding this comment.
There are a few other places where we lost data in the switch to the new API, but we also gained some too. I don't think we want to do too much manual tweaking, so I've removed your Jek adjustment for now (I think we'd either try to do all or nothing, and since Gregar and Corde also lost info, I think it is better to try to consistently do nothing right now)
Comment on lines
-58
to
+61
| Gregar Typho,185,85,black,dark,brown,NA,male,masculine,Naboo,Human,Attack of the Clones,,Naboo fighter | ||
| Cordé,157,NA,brown,light,brown,NA,female,feminine,Naboo,Human,Attack of the Clones,, | ||
| Plo Koon,188,80,none,orange,black,22,male,masculine,Dorin,Kel Dor,"The Phantom Menace, Attack of the Clones, Revenge of the Sith",,Jedi starfighter | ||
| Mas Amedda,196,NA,none,blue,blue,NA,male,masculine,Champala,Chagrian,"The Phantom Menace, Attack of the Clones",, | ||
| Gregar Typho,185,85,black,dark,brown,NA,NA,NA,Naboo,NA,Attack of the Clones,,Naboo fighter | ||
| Cordé,157,NA,brown,light,brown,NA,NA,NA,Naboo,NA,Attack of the Clones,, |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starwarsdata is no longer operational. I found 2 possible replacements (https://swapi.dev/about and https://swapi.py4e.com/about). The py4e site was more complete, so I used that one.