Use snapshots for errors that dplyr owns now

tests/testthat/_snaps/step-subset-slice.md

@@ -1,3 +1,49 @@
+# slice_*() checks for empty ...
+
+    Code
+      slice_head(dt, 5)
+    Condition
+      Error in `slice_head()`:
+      ! `n` must be explicitly named.
+      i Did you mean `slice_head(n = 5)`?
+    Code
+      slice_tail(dt, 5)
+    Condition
+      Error in `slice_tail()`:
+      ! `n` must be explicitly named.
+      i Did you mean `slice_tail(n = 5)`?
+    Code
+      slice_min(dt, x, 5)
+    Condition
+      Error in `slice_min()`:
+      ! `n` must be explicitly named.
+      i Did you mean `slice_min(n = 5)`?
+    Code
+      slice_max(dt, x, 5)
+    Condition
+      Error in `slice_max()`:
+      ! `n` must be explicitly named.
+      i Did you mean `slice_max(n = 5)`?
+    Code
+      slice_sample(dt, 5)
+    Condition
+      Error in `slice_sample()`:
+      ! `n` must be explicitly named.
+      i Did you mean `slice_sample(n = 5)`?
+
+---
+
+    Code
+      slice_min(dt)
+    Condition
+      Error in `slice_min()`:
+      ! `order_by` is absent but must be supplied.
+    Code
+      slice_max(dt)
+    Condition
+      Error in `slice_max()`:
+      ! `order_by` is absent but must be supplied.
+
 # check_slice_catches common errors
 
     Code

tests/testthat/test-step-subset-slice.R

@@ -127,14 +127,19 @@ test_that("arguments to sample are passed along", {
 
 test_that("slice_*() checks for empty ...", {
   dt <- lazy_dt(data.frame(x = 1:10))
-  expect_error(slice_head(dt, 5), class = "rlib_error_dots_nonempty")
-  expect_error(slice_tail(dt, 5), class = "rlib_error_dots_nonempty")
-  expect_error(slice_min(dt, x, 5), class = "rlib_error_dots_nonempty")
-  expect_error(slice_max(dt, x, 5), class = "rlib_error_dots_nonempty")
-  expect_error(slice_sample(dt, 5), class = "rlib_error_dots_nonempty")
-
-  expect_error(slice_min(dt), "missing")
-  expect_error(slice_max(dt), "missing")
+
+  expect_snapshot(error = TRUE, {
+    slice_head(dt, 5)
+    slice_tail(dt, 5)
+    slice_min(dt, x, 5)
+    slice_max(dt, x, 5)
+    slice_sample(dt, 5)
+  })
+
+  expect_snapshot(error = TRUE, {
+    slice_min(dt)
+    slice_max(dt)
+  })
 })
 
 test_that("slice_*() checks for constant n= and prop=", {