Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support factors #88

Open
multimeric opened this issue Dec 1, 2023 · 3 comments
Open

Support factors #88

multimeric opened this issue Dec 1, 2023 · 3 comments
Labels
feature a feature request or enhancement

Comments

@multimeric
Copy link

I know this is a known issue, but it I feel like it could do with an issue for tracking purposes.

Replication:

> duckplyr:::duckdb_rel_from_df(iris)
Error in duckplyr:::duckdb_rel_from_df(iris) : 
  Can't convert factor columns to relational. Affected column: `Species`.
@grantmcdermott
Copy link

grantmcdermott commented Apr 4, 2024

Factor support could be implemented via enum types, no? Or, am I missing something obvious?

@BlackEdder
Copy link

Doing some digging it looks like there was a missing feature in duckdb, which made it complicated, but that bug is now solved! Hopefully factors can be enabled soon.

@krlmlr
Copy link
Member

krlmlr commented Jul 10, 2024

While we can add support for factors, enabling this will almost certainly unlock test failures that were hidden before because we had a fallback as soon as factors were present.

Action items:

  • Enable
  • Fix internal tests
  • Run revdepchecks, fix

@krlmlr krlmlr added the feature a feature request or enhancement label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants