Use ellipsis to check for unmatched ...

Fixes #174
tidyverse · Feb 14, 2019 · 74830eb · 74830eb · jthomasmock · Feb 14, 2019
1 parent 3f789ee
commit 74830eb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -20,6 +20,7 @@ BugReports: https://github.com/tidyverse/forcats/issues
 Depends: 
     R (>= 3.1)
 Imports: 
+    ellipsis,
     magrittr,
     rlang,
     tibble

diff --git a/R/as_factor.R b/R/as_factor.R
@@ -14,6 +14,7 @@
 #' as_factor(x)
 #' as.factor(x)
 as_factor <- function(x, ...) {
+  ellipsis::check_dots_used()
   UseMethod("as_factor")
 }
 

diff --git a/R/reorder.R b/R/reorder.R
@@ -40,6 +40,7 @@
 fct_reorder <- function(.f, .x, .fun = median, ..., .desc = FALSE) {
   f <- check_factor(.f)
   stopifnot(length(f) == length(.x))
+  ellipsis::check_dots_used()
 
   summary <- tapply(.x, .f, .fun, ...)
   if (!is.numeric(summary)) {
@@ -54,6 +55,7 @@ fct_reorder <- function(.f, .x, .fun = median, ..., .desc = FALSE) {
 fct_reorder2 <- function(.f, .x, .y, .fun = last2, ..., .desc = TRUE) {
   f <- check_factor(.f)
   stopifnot(length(f) == length(.x), length(.x) == length(.y))
+  ellipsis::check_dots_used()
 
   summary <- tapply(seq_along(.x), f, function(i) .fun(.x[i], .y[i], ...))
   if (!is.numeric(summary)) {