Add weight argument to fct_infreq #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
commented
Jan 3, 2023
R/reorder.R
Outdated
| @@ -134,10 +134,23 @@ fct_inorder <- function(f, ordered = NA) { | |||
|
|
|||
| #' @export | |||
| #' @rdname fct_inorder | |||
| fct_infreq <- function(f, ordered = NA) { | |||
| #' @param weight Optional vector of numeric values to weight by. | |||
| fct_infreq <- function(f, weight = NULL, ordered = NA) { | |||
There was a problem hiding this comment.
fct_lump() and the other functions in that family use w FWIW
I don't think there are any other weighted forcats functions to compare with.
DavisVaughan
approved these changes
Jan 3, 2023
R/reorder.R
Outdated
| @@ -134,10 +134,23 @@ fct_inorder <- function(f, ordered = NA) { | |||
|
|
|||
| #' @export | |||
| #' @rdname fct_inorder | |||
| fct_infreq <- function(f, ordered = NA) { | |||
| #' @param weight Optional vector of numeric values to weight by. | |||
| fct_infreq <- function(f, weight = NULL, ordered = NA) { | |||
There was a problem hiding this comment.
fct_lump() and the other functions in that family use w FWIW
I don't think there are any other weighted forcats functions to compare with.
R/reorder.R
Outdated
Comment on lines
137
to
138
| fct_infreq <- function(f, ordered = NA) { | ||
| #' @param weight Optional vector of numeric values to weight by. | ||
| fct_infreq <- function(f, weight = NULL, ordered = NA) { |
There was a problem hiding this comment.
Do you expect the argument ordering here to matter? Probably not much? i.e. if someone specified ordered without naming the argument. Seems unlikely
There was a problem hiding this comment.
Yeah, I think that seems ok
Co-authored-by: Davis Vaughan <davis@rstudio.com>
#Conflicts: # NEWS.md # tests/testthat/test-reorder.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261