Skip to content

Commit

Permalink
Do not use RStudio Package Manager for R-devel (#4242)
Browse files Browse the repository at this point in the history
* Do not use RStudio Package Manager for R-devel

* Skip test when xml2 is not available

* Remove workaround for systemfonts
  • Loading branch information
yutannihilation committed Oct 22, 2020
1 parent 8aead50 commit 7e51849
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/R-CMD-check.yaml
Expand Up @@ -10,7 +10,7 @@ name: R-CMD-check

# Increment this version when we want to clear cache
env:
cache-version: v3
cache-version: v4

jobs:
R-CMD-check:
Expand All @@ -24,7 +24,7 @@ jobs:
config:
- {os: windows-latest, r: '4.0', vdiffr: true, xref: true}
- {os: macOS-latest, r: '4.0', vdiffr: true, xref: true}
- {os: ubuntu-16.04, r: 'devel', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest", http-user-agent: "R/4.0.0 (ubuntu-16.04) R (4.0.0 x86_64-pc-linux-gnu x86_64 linux-gnu) on GitHub Actions"}
- {os: ubuntu-16.04, r: 'devel', vdiffr: false, xref: true}
- {os: ubuntu-16.04, r: '4.0', vdiffr: true, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.6', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
- {os: ubuntu-16.04, r: '3.5', vdiffr: false, xref: true, rspm: "https://packagemanager.rstudio.com/cran/__linux__/xenial/latest"}
Expand Down
4 changes: 1 addition & 3 deletions tests/testthat/test-ggsave.R
Expand Up @@ -29,9 +29,7 @@ test_that("ggsave restores previous graphics device", {
})

test_that("ggsave uses theme background as image background", {
# FIXME: This should check svglite, but, at the time of writing this, there's already a binary
# package of svglite, and it can be installed even if the dependency is not available, surprisingly...
skip_if_not_installed("systemfonts")
skip_if_not_installed("xml2")

path <- tempfile()
on.exit(unlink(path))
Expand Down

0 comments on commit 7e51849

Please sign in to comment.