Skip to content

Commit

Permalink
Prepare for submission
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Nov 8, 2016
1 parent 7f04c25 commit f442f32
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 27 deletions.
9 changes: 4 additions & 5 deletions DESCRIPTION
@@ -1,8 +1,8 @@
Package: ggplot2
Version: 2.1.0.9001
Version: 2.2.0
Title: Create Elegant Data Visualisations Using the Grammar of Graphics
Description: ggplot2 is a system for declaratively creating graphics,
based on "The Grammar of Graphics". You provide the data, tell ggplot2
Description: A system for 'declaratively' creating graphics,
based on "The Grammar of Graphics". You provide the data, tell 'ggplot2'
how to map variables to aesthetics, what graphical primitives to use,
and it takes care of the details.
Authors@R: c(
Expand All @@ -19,7 +19,7 @@ Imports:
MASS,
plyr (>= 1.7.1),
reshape2,
scales (>= 0.4.0.9003),
scales (>= 0.4.1),
stats,
tibble,
lazyeval
Expand All @@ -41,7 +41,6 @@ Suggests:
rpart,
rmarkdown,
svglite
Remotes: hadley/scales
Enhances: sp
License: GPL-2 | file LICENSE
URL: http://ggplot2.tidyverse.org, https://github.com/tidyverse/ggplot2
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
@@ -1,4 +1,4 @@
# ggplot2 2.1.0.9000
# ggplot2 2.2.0

## Major new features

Expand Down
34 changes: 19 additions & 15 deletions cran-comments.md
Expand Up @@ -5,7 +5,7 @@

## R CMD check results

There were no ERRORs or WARNINGs. I see one NOTE:
There were no ERRORs or WARNINGs. I see two NOTEs:

* Found the following (possibly) invalid URLs:
URL: http://fueleconomy.gov
Expand All @@ -16,24 +16,28 @@ There were no ERRORs or WARNINGs. I see one NOTE:
`curl http://fueleconomy.gov` works, but `curl -I http://fueleconomy.gov`
(which sends a HEAD request) does not.

* checking DESCRIPTION meta-information ... NOTE
Authors@R field gives persons with non-standard roles:
RStudio [cph, fnd]: fnd

I would rely like to capture the signficant funders in the authors list
so that can be correctly acknowledged.

## Reverse dependencies

* I ran `R CMD check` on 954 all reverse dependencies
(summary at https://github.com/hadley/ggplot2/blob/master/revdep/).

* Maintainers with NOTEs, WARNINGs, or ERRORS were notified on Oct 6,
Oct 6, and again today.
Oct 25, and again today.

* There are a lot of WARNINGS/ERRORs, but I've carefully reviewed them
all and as far as I can tell they are either deliberate changes to
the ggplot2 API, or unrelated problems. I'm sorry there are so many -
I don't know how to better encourage package authors to submit
updates. Every maintainer has been personally emailed at least twice.

* I given a more detailed breakdown of ERRORs/WARNINGs
(but not NOTEs below). Please let me know if there's anything else I
can do to make this more helpful.

updates. Every maintainer has been personally emailed at least twice
before today.

### ggproto mistake

I unfortunately made an implementation error in ggproto (the OO system that ggplot2 uses) that inadvertently introduced a build-time dependency on ggplot2. I've fixed the problem and added a clear error message, but to fix a number of downstream failures will require a rebuild of the following packages against the new version of ggplot2:
Expand Down Expand Up @@ -67,14 +71,14 @@ This problem affects the following downstream packgaes:

### ggplot2 changes

Need dev version of plotly: the maintainer is planning on submitting ASAP.
Need dev version of plotly: the maintainer is planning on submitting ASAP:

* eechidna: checking examples ... ERROR
* heatmaply: checking examples ... ERROR
* MendelianRandomization: checking examples ... ERROR
* plotly: checking examples ... ERROR

Errors that were likely silently before, but now break thanks to stricter checks:
Errors that were silent, but now break thanks to stricter checks:

* biogram: checking re-building of vignette outputs ... WARNING
* BlandAltmanLeh: checking re-building of vignette outputs ... WARNING
Expand All @@ -97,7 +101,7 @@ Errors that were likely silently before, but now break thanks to stricter checks
* survMisc: checking examples ... ERROR
* UpSetR: checking re-building of vignette outputs ... WARNING

Relying on ggplot2 internals, and haven't yet updated code for this version.
Some packages rely on internal object definitions, and haven't yet been updated for this version:

* geomnet: checking examples ... ERROR
* GGally: checking examples ... ERROR
Expand All @@ -110,14 +114,14 @@ Relying on ggplot2 internals, and haven't yet updated code for this version.
* tabplot: checking examples ... ERROR
* vdmR: checking examples ... ERROR

Uses newly deprecated argument
Two use a newly deprecated argument:

* plotluck: checking tests ... ERROR
* robCompositions: checking re-building of vignette outputs ... WARNING

### Unrelated
### Problems unrelated to ggplot2

Failed to installed suggested package used in examples or vignettes
Failed to installed suggested package used in examples or vignettes:

* bcrm: checking examples ... ERROR
* BCEA: checking examples ... ERROR
Expand Down Expand Up @@ -198,7 +202,7 @@ Failed to install: BACCT, backShift, bamdit, brainGraph, bsam, BTSPAS,

### False positives

These seem to be false positives: neither I nor the maintainers could reproduce outside of my revdep check setup.
These seem to be a couple of false positives: neither I nor the maintainers could reproduce outside of my revdep check setup:

* radiant.model: checking examples ... ERROR
* data.table: checking tests ... ERROR
4 changes: 2 additions & 2 deletions man/ggplot2-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion revdep/check.R
Expand Up @@ -10,4 +10,4 @@ revdep_check(threads = 6, skip = to_skip)
revdep_check_save_summary()
revdep_check_print_problems()

# revdep_email(date = "Nov 4", version = "2.2.0", only_problems = TRUE, draft = FALSE)
# revdep_email(date = "Nov 8", version = "2.2.0", only_problems = TRUE, draft = FALSE)
4 changes: 1 addition & 3 deletions revdep/email.md
@@ -1,6 +1,6 @@
Hi,

This is an automated email to let you know about the upcoming release of {{{ my_package }}}, which will be submitted to CRAN next week. I'm aiming for {{{ date }}}, but that date may move backwards if significant problems are uncovered. To check for potential problems, I ran `R CMD check` on your package {{{your_package}}} ({{{your_version}}}).
This is an automated email to let you know that I have submitted {{{ my_package }}} to cran today {{{ date }}}. To check for potential problems, I ran `R CMD check` on your package {{{your_package}}} ({{{your_version}}}).

I found: {{{your_summary}}}.

Expand All @@ -9,8 +9,6 @@ I found: {{{your_summary}}}.

If I got an ERROR because I couldn't install your package (or one of it's dependencies), my apologies. Unfortunately I don't have the time to diagnose installation failures so you'll need to run the check yourself.

Compared to the last set of checks, there is one big change: I discovered a major issue with ggproto which made it unexpectedly fragile. I have fixed the bug, but any package that provides an extension will need to be rebuilt. I will ask CRAN to do this for all packages on CRAN, but when checking your own package you will need to do it yourself.

Otherwise, please determine if this is a problem with my code or your code. If you think it's a problem with {{ my_package}}, please file an issue on github that attempts to recreate the problem with as little code as possible. If it's a problem with your code, please prepare an updated package for CRAN as soon as possible. The ERRORs and WARNINGs might not be caused by the update to {{{my_package}}}, but it really makes life easier (for both me and CRAN) if you also fix any other problems that may have accumulated over time. Please also try to minimise the NOTEs. It's not essential you do this, but the fewer the false positives the more likely we are to detect a real problem with your package.

To get the development version of {{{ my_package }}} so you can run the checks yourself, you can run:
Expand Down

0 comments on commit f442f32

Please sign in to comment.