-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels can overlap in coord_sf() #2119
Comments
Can you please create your reprex with the reprex package? |
@hadley I cannot because:
I don't have time to dig through it. However just copypasting the code results in this. Look at the bottom left labels. This is with the gitHub version of |
Thanks; I can see what goes wrong; we need to check whether this needs to be solved on the Also, I see a 38N (or 38N and 36N overplotted?) at the top left that is placed wrongly as well. |
Thanks Edzer, yes something is wrong at the top left as well. Thanks for taking a look at it, this is currently preventing me from using |
fixes #375 sf side fix of tidyverse/ggplot2#2119
You'll need this PR, along with a fresh sf checkout from github. |
* addresses #2119 * tidy graticule fixes * ggplot2 side of issue r-spatial/sf#396 * tabs -> spaces * add ndiscr to docs
* addresses #2119 * tidy graticule fixes * ggplot2 side of issue r-spatial/sf#396 * tabs -> spaces * add ndiscr to docs * fix #2200 * attempt to fix #2060 All cases were in sf.R a geometry column is address with x$geometry, ggplot2 made the wrong assumption that the geometry column has a fixed name. I replaced this in certain instances, where the data are already pretty transformed and no longer have properties of sf objects, with a fixed position, i.e. x[[1]], which seems to work. * fixes r-spatial/sf#438 * address review comments * fix break on geom_raster, objects without list-column see https://gist.github.com/mdsumner/573ec70014df177baa2d1df7e55e1943 for the case that this PR fixes * tidy up * trying @karawoo's suggestion * adds some sf tests * tidy further
Labels in
coord_sf()
sometimes overlap. This happens when one of the grid lines has some part inside of the plot, but intersect an axis outside of the plot.See reprex below, look at the bottom left corner, 80W and 82W overlap.
The text was updated successfully, but these errors were encountered: