Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to include count & density to fix the use of geom_hexbin #1688

Closed
wants to merge 13 commits into from
Closed

Updates to include count & density to fix the use of geom_hexbin #1688

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cf99003
Updates to include count & density to fix the use of geom_hexbin with…
mikebirdgeneau May 28, 2016
058389d
Update hexbin.R
mikebirdgeneau Aug 2, 2016
75df121
Update bullet in NEWS
mikebirdgeneau Aug 2, 2016
7265c26
Add simple test for geom_hex to include density and value summaries f…
mikebirdgeneau Aug 2, 2016
f97b18b
Update NEWS
mikebirdgeneau Aug 2, 2016
9912f3b
Update hexbin.R
mikebirdgeneau Aug 2, 2016
58cdbb4
Remove accidental commit before renaming file.
mikebirdgeneau Aug 2, 2016
036f649
Merge branch 'master' of github.com:mikebirdgeneau/ggplot2
mikebirdgeneau Aug 2, 2016
5abb77c
Move code from within `hexBinSummarise` to within StatBinhex$compute_…
mikebirdgeneau Aug 3, 2016
d086c53
Correct bracket indentation.
mikebirdgeneau Aug 3, 2016
2e59e32
Update News bullet placement.
mikebirdgeneau Aug 5, 2016
dfe825f
Update NEWS
mikebirdgeneau Aug 5, 2016
06f4c6a
Update NEWS.md
mikebirdgeneau Aug 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions R/hexbin.R
View file
Open in desktop
Expand Up @@ -31,6 +31,8 @@ hexBinSummarise <- function(x, y, z, binwidth, fun = mean, fun.args = list(), dr

# Convert to data frame
out <- as.data.frame(hexbin::hcell2xy(hb))
out$count = as.vector(hb@count)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use <- instead of =?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I'm not sure that the code should go here - it's only needed for hexbin, not the other summary functions.

out$density = as.vector(hb@count / sum(hb@count, na.rm = TRUE))
out$value <- as.vector(value)

if (drop) out <- stats::na.omit(out)
Expand Down