Add support for sf [WIP] #1990
Merged
Add support for sf [WIP] #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
force-pushed
the
sf
branch
2 times, most recently
from
5ffd5bc
to
155d931
Compare
Using crs recorded in coord
Improve docs
(For graticules that don't intersect with the bounding box)
cpsievert
reviewed
Feb 8, 2017
| # Wrapper around is.finite to handle list cols | ||
| is_finite <- function(x) { | ||
| if (typeof(x) == "list") { | ||
| !vapply(x, is.null, logical(1)) |
There was a problem hiding this comment.
should this be !vapply(x, is.finite, logical(1))?
There was a problem hiding this comment.
Anything could be inside that list (like another list) - being finite doesn't really have a meaning for arbitrary elements so this just drops rows where the list-col is empty.
# Conflicts: # DESCRIPTION # NEWS.md
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.