Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add informative error message if user forgets data arg in ggplot() #2056

Merged
merged 4 commits into from Jun 14, 2017
Merged

Add informative error message if user forgets data arg in ggplot() #2056

merged 4 commits into from Jun 14, 2017

Commits on Jun 12, 2017

  1. Add helpful error message 

    The error message "gglot2 doesn't know how to deal with data of class uneval" is one of the more common ones that I see, and one that perplexes new users of ggplot2. I added a note about the most common reason for and fix of this error message.
    @jrnold
    jrnold committed Jun 12, 2017
    Copy the full SHA
    b93b143 View commit details
    Browse the repository at this point in the history

  2. Fix hadley comments in tidyverse#2056 

    - add ticks around `data` in message
- use `inherits` instead of equals when testing class
    @jrnold
    jrnold committed Jun 12, 2017
    Copy the full SHA
    f084888 View commit details
    Browse the repository at this point in the history

  3. fix fortify test 

    Needed after updates to the message
    @jrnold
    jrnold committed Jun 12, 2017
    Copy the full SHA
    3a506f5 View commit details
    Browse the repository at this point in the history

  4. improve error message 

    As noted by @hadley in tidyverse#2056, the warning for `uneval` also appears in geoms as well as ggplot()
    @jrnold
    jrnold committed Jun 12, 2017
    Copy the full SHA
    c46184d View commit details
    Browse the repository at this point in the history