Implement sec.axis for date, time, and datetime scales #2806
Conversation
Can you add an example showing a meaningful use of a Date transformation in the secondary axis? |
if (!is.sec_axis(sec.axis)) stop("Secondary axes must be specified using 'sec_axis()'") | ||
sc$secondary.axis <- sec.axis | ||
} | ||
sc |
thomasp85
Aug 10, 2018
Member
It seems this check is now so common that it should be factored out into a separate function
It seems this check is now so common that it should be factored out into a separate function
Merge remote-tracking branch 'upstream/master' into sec_date # Conflicts: # NEWS.md # man/scale_date.Rd # tests/testthat/test-sec-axis.R
Thanks @thomasp85. 4 things:
|
@thomasp85 can you please re-review? |
Merge remote-tracking branch 'upstream/master' into sec_date # Conflicts: # NEWS.md
@dpseidel For your last bullet point, do you mean adding these parameters to the function |
@clauswilke I was intending to inquire about the former solution -- adding these as arguments to Thanks for all your work pushing out this bug release! This last one of mine is pretty close, I'm just waiting on a final review. I've synced this branch with master now and may add more tests today to bring the codecov percentage up but otherwise, we should be near finished. |
@thomasp85 Any more comments from your end? |
I’m going to do a review this evening |
I think this is fine as-is. Agree that sec_axis() shouldn't get date specific arguments... Thanks for all your work on this Dana |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This PR implements secondary axes for date, time, datetime scales. Closes #2244.