Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid stripping .data pronoun during evaluation #3850

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Avoid stripping .data pronoun during evaluation #3850

merged 3 commits into from
Mar 3, 2020

Conversation

thomasp85
Copy link
Member

This fixes a regression in the .data stripping code for default labels that would remove it before evaluation as well

@thomasp85 thomasp85 added this to the ggplot2 3.3.0 milestone Mar 3, 2020
@thomasp85 thomasp85 requested a review from hadley March 3, 2020 20:06
hadley
hadley reviewed Mar 3, 2020
View reviewed changes
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to use strip_pronoun = TRUE in label making code. Otherwise looks good — I double checked that the new arg is passed all the way down.

@thomasp85
Copy link
Member Author

Classic example of forgetting to save the file before committing :-)

@thomasp85 thomasp85 merged commit 4f51f51 into v3.3.0-rc Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasp85 @hadley