Adds support of rlang::list2
dynamic dots
#4764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the dynamic dots management (
...
) frombase::list
torlang::list2
, see #4752The functions modified are the one of the Public API that accepts
...
as arguments.In total 89 functions have been update, they include:
geom_*
stat_*
lims
,expand_limits
aes_
,aes_string
coord_map
annatation
,annotation_map
,annotation_logticks
Here there is the script that I have used to find the functions that use
...
withlist
https://gist.github.com/mone27/285f022b9efbb4bc244acb6622f3411eThe PR should be complete, possible additional steps are:
rlang
...
https://rlang.r-lib.org/reference/dyn-dots.html#add-dynamic-dots-support-in-your-functions. However, inggplot
most of the...
are actually not documented.