Unknown theme elements throw warnings instead of errors #5743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
approved these changes
Mar 18, 2024
| @@ -293,7 +293,7 @@ test_that("incorrect theme specifications throw meaningful errors", { | |||
| test_that("element tree can be modified", { | |||
| # we cannot add a new theme element without modifying the element tree | |||
| p <- ggplot() + theme(blablabla = element_text(colour = "red")) | |||
| expect_snapshot_error(print(p)) | |||
There was a problem hiding this comment.
Wouldn't this require an update of the snapshot
There was a problem hiding this comment.
The message is exactly the same so the snapshot file hasn't changed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5719.
Briefly, when declaring an unknown theme element, we throw a warning instead of error. The offending theme element is then removed from the theme.
This is more gentle if you make a typo or for us if we want to deprecate theme arguments.
Reprex from the issue:
Created on 2024-03-05 with reprex v2.1.0