Wrap glue errors, if possible #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
commented
Jan 26, 2023
DavisVaughan
approved these changes
Jan 27, 2023
Co-authored-by: Davis Vaughan <davis@rstudio.com>
#Conflicts: # DESCRIPTION # R/sql.R
#Conflicts: # NEWS.md
jennybc
reviewed
Nov 28, 2023
tests/testthat/_snaps/transformer.md
Outdated
| Error: | ||
| ! Failed to evaluate glue component {NOTFOUND} | ||
| Caused by error in `identity_transformer()`: | ||
| ! argument "envir" is missing, with no default |
There was a problem hiding this comment.
This doesn't seem to be the error we're trying to test.
After staring long and hard at the CI failures, I realized this. I was puzzled why the R version mattered, since we're using rlang::abort(). But this error is coming from base R.
|
I think we either have to give |
|
Yeah, that looks right to me. Not sure how I missed it originally. |
jennybc
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229