Test that labels are unique (#364)

NEWS.md

@@ -1,5 +1,7 @@
 # haven (development version)
 
+* `labelled()` tests that value labels are unique (@larmarange, #364).
+
 * `as_factor(x)` is now faster when `x` does not contain any missing values
   (@hughparsonage).
 

R/labelled.R

@@ -48,6 +48,9 @@ labelled <- function(x, labels, label = NULL) {
   if (is.null(names(labels))) {
     stop("`labels` must have names", call. = FALSE)
   }
+  if (any(duplicated(stats::na.omit(labels)))) {
+    stop("`labels` must be unique", call. = FALSE)
+  }
   if (!is.null(label) && (!is.character(label) || length(label) != 1)) {
     stop("`label` must be a character vector of length one", call. = FALSE)
   }

tests/testthat/test-labelled.R

@@ -23,6 +23,10 @@ test_that("label must be length 1 character or missing", {
                "character vector of length one")
 })
 
+test_that("labels must be unique", {
+  expect_error(labelled(1, c(female = 1, male = 1)), "must be unique")
+})
+
 # methods -----------------------------------------------------------------
 
 test_that("printed output is stable", {

tests/testthat/test-labelled_spss.R

@@ -32,6 +32,11 @@ test_that("subsetting preserves attributes", {
   expect_identical(x, x[])
 })
 
+test_that("labels must be unique", {
+  expect_error(
+    labelled_spss(1, c(female = 1, male = 1), na_values = 9),
+    "must be unique")
+})
 
 # is.na -------------------------------------------------------------------