Make interval equality operator compare start and end of intervals #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jakemanger, there is a failure in pkgdown. I think you need to declare it in the index. More importantly, Should we add inequalities as well, for full partial order implementation? Also could you please test for vectorized operations, not just single-tons, and add a new-features news entry? Thanks!!! |
|
Hi @vspinu I've declared == and != in the index and have added inequalities and vector support. That vectors test was important, as I had used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An approach to Fix #1135
This changes the default behaviour from comparing the interval duration to comparing the start and end of the interval, which I believe is more intuitive (it has slipped me up before). However, would this require a warning to notify users that the default behaviour has changed?