New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`purrr:::capture_output()` should use `conditionMessage()` not `$message` #1010

Closed

DavisVaughan opened this issue Dec 15, 2022 · 0 comments · Fixed by #1012

Member

DavisVaughan commented Dec 15, 2022 •

edited

> purrr:::capture_output
function (code) 
{
    warnings <- character()
    wHandler <- function(w) {
        warnings <<- c(warnings, w$message)
        invokeRestart("muffleWarning")
    }
    messages <- character()
    mHandler <- function(m) {
        messages <<- c(messages, m$message)
        invokeRestart("muffleMessage")
    }

To give things like rlang:::conditionMessage.rlang_error a chance to run correctly

The text was updated successfully, but these errors were encountered:

hadley added a commit that referenced this issue


          Use conditionMessage()

00cdddb

Fixes #1010

hadley mentioned this issue

Use conditionMessage() #1012

Merged

hadley closed this as completed in #1012

hadley added a commit that referenced this issue


          Use conditionMessage() (#1012)

d1b8464

Fixes #1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment