Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal support for raw vectors. #455

Merged
merged 3 commits into from Feb 20, 2018
Merged

minimal support for raw vectors. #455

merged 3 commits into from Feb 20, 2018

Conversation

romainfrancois
Copy link
Member

cleaner version of #345
I manually applied the changes from the broken PR to the current master

@romainfrancois
Copy link
Member Author

🤔 the failures seem related to the .default argument in map:

https://travis-ci.org/tidyverse/purrr/jobs/337610412#L1150

@hadley
Copy link
Member

hadley commented Feb 8, 2018

Yeah, that was my fault - can you please merge/rebase from master?

@romainfrancois
Copy link
Member Author

So I have

$ git remote -v
origin	https://github.com/romainfrancois/purrr.git (fetch)
origin	https://github.com/romainfrancois/purrr.git (push)
upstream	https://github.com/tidyverse/purrr.git (fetch)
upstream	https://github.com/tidyverse/purrr.git (push)

and then I've done

git fetch upstream
git merge upstream/master
git push

I might have to properly learn about rebase some day.

@romainfrancois
Copy link
Member Author

I guess I was close with my rebase attempts and all I needed really was the -f as described in https://gist.github.com/ravibhure/a7e0918ff4937c9ea1c456698dcd58aa

DESCRIPTION Outdated
@@ -25,4 +25,5 @@ Suggests:
VignetteBuilder: knitr
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 6.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the released version of roxygen2?

@hadley
Copy link
Member

hadley commented Feb 12, 2018

Can you please also add a bullet to NEWS?

@romainfrancois
Copy link
Member Author

I think I managed to do a clean rebase this time 🎉

@hadley
Copy link
Member

hadley commented Feb 19, 2018

Looks good!

Can you please add a bullet to NEWS? It should briefly describe the change (starting with name of the function), and crediting yourself with (@yourname, #issuenumber).

@romainfrancois
Copy link
Member Author

Done. Does it make sense to do the same for complex for completeness or is it a maintenance burden down the line ?

@hadley
Copy link
Member

hadley commented Feb 20, 2018

I don't see the benefit to doing it until someone has expressed a need.

@hadley hadley merged commit 84ce1ad into tidyverse:master Feb 20, 2018
@hadley
Copy link
Member

hadley commented Feb 20, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants