Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of arguments with 1e vs 2e differences #1427

Open
jennybc opened this issue Aug 28, 2022 · 2 comments
Open

Handling of arguments with 1e vs 2e differences #1427

jennybc opened this issue Aug 28, 2022 · 2 comments
Labels
lifecycle 🦋 upkeep maintenance, infrastructure, and similar

Comments

@jennybc
Copy link
Member

jennybc commented Aug 28, 2022

While reviewing #1426, it occurs to me that the name_repair argument is completely unsupported in 1e. readr 1e has its own DIY name repair strategies hard-wired in. We should document that.

And now that I'm thinking about this, I'm quite sure other arguments are in a similar boat, i.e. only have an effect in 1e or have different behaviours in 1e vs 2e. We should have some standard wording for this.

@jennybc jennybc changed the title Document arguments with 1e vs 2e differences Handling of arguments with 1e vs 2e differences Aug 28, 2022
@jennybc
Copy link
Member Author

jennybc commented Aug 28, 2022

Thinking about a gradual process for phasing out 1e, we should also think about warning when a 1e user uses an argument that only exists for 2e. As it stands, we (almost?) always just quietly ignore that.

@jennybc
Copy link
Member Author

jennybc commented Aug 28, 2022

Clearly related to tidyverse/vroom#461

@hadley hadley added the upkeep maintenance, infrastructure, and similar label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle 🦋 upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants