problems() not pulling up the exact text of a parsing failure

[kendonB]

The example:

library(tidyverse)
x <- tribble(
  ~unit, ~value,
  "a"  ,    "1",
  "b"  ,     "(NA)")
write_tsv(x, path = "test.tsv")

Now try and parse with the incorrect NA specification (in the real application it's not obvious exactly what represents NA).

new_x <- read_tsv("test.tsv",
                  na = "",
                  col_types = cols(
                      unit = col_character(),
                      value = col_number()
                    ))
file.remove("test.tsv")

problems(new_x)
# A tibble: 1 × 4
#     row   col expected actual
#   <int> <chr>    <chr>  <chr>
# 1     2 value a number       

I would have expected this to come up:

# A tibble: 1 × 4
#   row     col expected actual
# <int>   <chr>    <chr>  <chr>
# 1   2   value a number   (NA) 

Is this the expected behavior?

[hadley]

Simpler reprex:

problems(read_tsv("x\n1\nx", na = "", col_types = "n"))

This is ok:

problems(read_tsv("x\n1\nx", na = "", col_types = "d"))

So probably a buglet in the number collector.

[kendonB]

Thanks for the fix!

I found another case which fails, even after the fix:

problems(read_tsv("(-)\n1\n(-)", na = "", col_types = "n"))

[jimhester]

Looks correct to me, what do you expect the output to be?

library(readr)
problems(read_tsv("(-)\n1\n(-)", na = "", col_types = "n"))
#> # A tibble: 1 × 4
#>     row   col expected actual
#>   <int> <chr>    <chr>  <chr>
#> 1     2   (-) a number      -

[kendonB]

The "-" should be "(-)". On mobile. On Feb 24, 2017 1:54 PM, "Jim Hester" <notifications@github.com> wrote: Looks correct to me, what do you expect the output to be? library(readr) problems(read_tsv("(-)\n1\n(-)", na = "", col_types = "n"))#> # A tibble: 1 × 4#> row col expected actual#> <int> <chr> <chr> <chr>#> 1 2 (-) a number - — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#548 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFFKkXhSFmqRZecvols5EwB6AUgJp3Pgks5rf1GRgaJpZM4Kqpu2> .