Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fwf_cols function #616

Merged
merged 24 commits into from Feb 27, 2017
Merged

Add fwf_cols function #616

merged 24 commits into from Feb 27, 2017

Commits on Feb 18, 2017

  1. Add fwf_cols function

    This adds a helper function `fwf_cols` that is a more intuitive way of specifying fixed width column start and end points. While `fwf_positions` requires three vectors for start, end, and names, `fwf_cols` accepts a named list of length-2 vectors of the column start and end positions.
    jrnold committed Feb 18, 2017
    Copy the full SHA
    59a1422 View commit details
    Browse the repository at this point in the history
  2. fix example for fwf_cols

    jrnold committed Feb 18, 2017
    Copy the full SHA
    80586ec View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2017

  1. Fix failed Travis build

    It needs the .Rd file.
    jrnold committed Feb 20, 2017
    Copy the full SHA
    e5cc862 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2017

  1. Add fwf_cols function

    This adds a helper function `fwf_cols` that is a more intuitive way of specifying fixed width column start and end points. While `fwf_positions` requires three vectors for start, end, and names, `fwf_cols` accepts a named list of length-2 vectors of the column start and end positions.
    jrnold committed Feb 23, 2017
    Copy the full SHA
    2b74406 View commit details
    Browse the repository at this point in the history
  2. fix example for fwf_cols

    jrnold committed Feb 23, 2017
    Copy the full SHA
    f954bc7 View commit details
    Browse the repository at this point in the history
  3. Fix failed Travis build

    It needs the .Rd file.
    jrnold committed Feb 23, 2017
    Copy the full SHA
    f9f2f4d View commit details
    Browse the repository at this point in the history
  4. Add fwf_cols function

    This adds a helper function `fwf_cols` that is a more intuitive way of specifying fixed width column start and end points. While `fwf_positions` requires three vectors for start, end, and names, `fwf_cols` accepts a named list of length-2 vectors of the column start and end positions.
    jrnold committed Feb 23, 2017
    Copy the full SHA
    03172a7 View commit details
    Browse the repository at this point in the history
  5. Updates to fwf_* column position functions

    - read_fwf arg col_positions will check for column names and whether the data frame is widths or a start/end data frame.
    - rewrite fwf_cols to accept named args of length 1 or 2. This makes it more concise. Also accept a data frame as the first argument
    - More checks for argument validity
    - Use tibbles instead of lists where appropriate
    
    Some tests failing. Still need to debug.
    jrnold committed Feb 23, 2017
    Copy the full SHA
    7a35bac View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2017

  1. fix failing tests

    jrnold committed Feb 24, 2017
    Copy the full SHA
    0d48bb2 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2017

  1. misc

    jrnold committed Feb 25, 2017
    Copy the full SHA
    980371b View commit details
    Browse the repository at this point in the history
  2. merge

    jrnold committed Feb 25, 2017
    Copy the full SHA
    08495c2 View commit details
    Browse the repository at this point in the history
  3. respond to hadley's comments

    Move fwf_col_names function lower in file.
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    8b942d7 View commit details
    Browse the repository at this point in the history
  4. respond to hadley's comments

    Add widths form of fwf_cols to documentation
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    24def9d View commit details
    Browse the repository at this point in the history
  5. respond to hadley's comments

    This is too complicated; since we have fwf_cols, don't worry about list inputs.
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    8a7ddff View commit details
    Browse the repository at this point in the history
  6. respond the hadley's comments

    Revert added newline
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    6370e0c View commit details
    Browse the repository at this point in the history
  7. respond to hadley's comments

    Remove a try() call since, the preference is for errors to bubble up to users.
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    0b29615 View commit details
    Browse the repository at this point in the history
  8. respond to hadley's comments

    This seems too flexible, so I'll change it to just use ...
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    c2cce8d View commit details
    Browse the repository at this point in the history
  9. Fix indenting issues

    See comments in tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    8610b4b View commit details
    Browse the repository at this point in the history
  10. fix tests

    - removed tests that failed after removing features in fwf_cols in previous commits
    - remove test that failed because fwf_positions changes columns to numeric
    jrnold committed Feb 25, 2017
    Copy the full SHA
    6640c3d View commit details
    Browse the repository at this point in the history
  11. respond to hadley's comments

    Revert this section in read_fwf since it is unnecessary to handle data list objects with the availability of fwf_cols
    
    See tidyverse#616
    jrnold committed Feb 25, 2017
    Copy the full SHA
    0651081 View commit details
    Browse the repository at this point in the history
  12. convert numeric constants in fwf functions

    Convert some numeric constants to integer constants so that addition/subtraction does not coerce columns to numeric if they were integer. This is not a big deal, but since the positions represent integers anyways, it might as well keep them as such if they are already specified as such.
    jrnold committed Feb 25, 2017
    Copy the full SHA
    9c912a3 View commit details
    Browse the repository at this point in the history
  13. add bullet point to NEWS.md

    jrnold committed Feb 25, 2017
    Copy the full SHA
    c22745c View commit details
    Browse the repository at this point in the history
  14. Copy the full SHA
    bfe64d7 View commit details
    Browse the repository at this point in the history
  15. fix merge error

    weird things happened to NEWS.md. They are fixed now.
    jrnold committed Feb 25, 2017
    Copy the full SHA
    e7a5b62 View commit details
    Browse the repository at this point in the history