-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report on named ranges #317
Comments
May I suggest that
|
Is / was there an PR from @eibanez that happened before my time or that I failed to really register, when I was working on fixing other stuff? BTW thanks for all the work re: thinking through this issue. |
I don't think I made an official PR. The changes are over 2 years old and, at the time, they weren't accepted in the upstream Unfortunately, I cannot work on further changes in the foreseeable future, but you are more than welcome to borrow the stuff from my branch. #79 has all the info. |
Ah, ok now I see my own note there. So it looks like we have finally gotten to the "might revisit later" point 🙂. |
I am on the fence. On one hand, it's possible a PR would be extremely helpful and I could merge when I revisit readxl this fall. It's also possible it would be easier for me to do once I upload all this into my head again, esp. if it integrates with other things I'm doing. I have a big internal integration of xls and xlsx coming and this would most naturally happen after that, because that will be a pretty major internal change. This named range work is much easier for xlsx than xls, but needs to happen for both. |
As I need this feature, I have gone ahead and written an implementation for it myself (see open PR). Please consider my PR. |
Now that readxl can read from a range, it would be nice to extract the named ranges, for possible use in a subsequent call to
read_excel(..., range = ...)
. There could be a metadata function, likeexcel_sheets()
, butexcel_ranges()
.Related to nacnudus/tidyxl#17 and #79 (in which I say we won't do this, but maybe I was wrong).
cc @sz-cgt @nacnudus
The text was updated successfully, but these errors were encountered: