Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor xlsx col type handling #261

Merged
merged 33 commits into from
Feb 13, 2017
Merged

Refactor xlsx col type handling #261

merged 33 commits into from
Feb 13, 2017

Commits on Feb 11, 2017

  1. add new param n for guessing col_type

    @tklebel
    tklebel authored and jennybc committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    d8481ab View commit details
    Browse the repository at this point in the history

  2. Remove all column name processing from colTypes()

    jennybc committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    2c8e6c2 View commit details
    Browse the repository at this point in the history

  3. Move colName and colType comparison out of readCols()

    jennybc committed Feb 11, 2017
    Configuration menu
    Copy the full SHA
    c4b12b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2017

  1. Stop dropping blank columns; fixes #157

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    9143dcb View commit details
    Browse the repository at this point in the history

  2. Move tests into more logical places

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    81643b6 View commit details
    Browse the repository at this point in the history

  3. More specific error when col_names or col_types has wrong length

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    3cf7dc9 View commit details
    Browse the repository at this point in the history

  4. Rcpp churn

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    bb567be View commit details
    Browse the repository at this point in the history

  5. If no data, call it blank right here

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    0c7e90f View commit details
    Browse the repository at this point in the history

  6. Simplify col_type learning loop

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    4657868 View commit details
    Browse the repository at this point in the history

  7. Sketch my grand plans

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    54213fd View commit details
    Browse the repository at this point in the history

  8. Check and test col_types

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    4eeddf2 View commit details
    Browse the repository at this point in the history

  9. Simplify readCols() loop

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    d100d5f View commit details
    Browse the repository at this point in the history

  10. Recycle col_types if length 1; fixes #127

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    624b02b View commit details
    Browse the repository at this point in the history

  11. Deprecate col_types = "blank"; fixes #260

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    8459ff9 View commit details
    Browse the repository at this point in the history

  12. Rationalize joint processing of col_names + col_types; fixes #81

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    6ab2d36 View commit details
    Browse the repository at this point in the history

  13. Ignore docs for xls format

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    65cd24b View commit details
    Browse the repository at this point in the history

  14. Fix/update xlsx_col_types() 

    Even though I'm not sure what it's for.
    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    b5c55ce View commit details
    Browse the repository at this point in the history

  15. Delete benchmarks.cpp, home of the shifty, vestigial parseXml()and co… 

    …untRows()
    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    80905cf View commit details
    Browse the repository at this point in the history

  16. Add bullets to NEWS

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    09562b1 View commit details
    Browse the repository at this point in the history

  17. README and pkgdown

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    4a90dec View commit details
    Browse the repository at this point in the history

  18. Groom error messages and tests thereof

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    0d57735 View commit details
    Browse the repository at this point in the history

  19. Wording in NEWS

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    3c10a4b View commit details
    Browse the repository at this point in the history

  20. Stop for unknown type

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    bba7655 View commit details
    Browse the repository at this point in the history

  21. Move CELL_SKIP; add comment re: enum order

    jennybc committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    3dab676 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2017

  1. Recycle length-one col_type with std::fill()

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    5f7f908 View commit details
    Browse the repository at this point in the history

  2. Indenting

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    b200038 View commit details
    Browse the repository at this point in the history

  3. Helper function for reconciling col names

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    158bbc4 View commit details
    Browse the repository at this point in the history

  4. Helper function for recycling col types

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    7d63e93 View commit details
    Browse the repository at this point in the history

  5. Simplify col_type learning loop; avoid cell copy

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    ee18b43 View commit details
    Browse the repository at this point in the history

  6. Simplify and avoid cell copy in readCols() too

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    5189042 View commit details
    Browse the repository at this point in the history

  7. It's guess_max, not max_guess

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    642e23c View commit details
    Browse the repository at this point in the history

  8. Delete comment, test code style

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    c45a0a7 View commit details
    Browse the repository at this point in the history

  9. Cleaner with i, j

    jennybc committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    6bb4ee3 View commit details
    Browse the repository at this point in the history