change warning for date before 1900-01-01 #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I have to set readxl aside for a while now, so that's why this will sit a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #551. It is based on a research I made for investigating #547 so I find it useful to share, in case this correspond to how you would have it fixed it.
I have just added a specific warning for 1900-02-29 and a general one for dates before 1900-01-01 that do not exist in excel.
I wanted to add some test in
test-dates.Rbut not sure how to do that for those date that do not exist in excel. It is also not easy because I am on an European Excel and it does not behave like english one. (If I opentest_sheet("dates-leap-year-1900-xlsx.xlsx")in Excel, it does not behave as expected).Please tell me if you think I can add some anyway.