Skip to content

Commit

Permalink
Submit to CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
jennybc committed Jun 22, 2018
1 parent 21b552c commit af513a4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
@@ -1,3 +1,4 @@
^CRAN-RELEASE$
^.*\.Rproj$
^\.Rproj\.user$
^README\.Rmd$
Expand Down
2 changes: 2 additions & 0 deletions CRAN-RELEASE
@@ -0,0 +1,2 @@
This package was submitted to CRAN on 2018-06-21.
Once it is accepted, delete this file and tag the release (commit 21b552c21c).
12 changes: 7 additions & 5 deletions cran-comments.md
@@ -1,14 +1,16 @@
This is an update of a package declared ORPHANED by CRAN in January.
This is an update of a package declared ORPHANED by CRAN in January 2018.

reprex is intended for interactive use and the clipboard has always been the user's primary means of providing input (a short piece of code) and the primary means of returning output (the rendered code). The package's use of the clipboard is now prominently documented in package Title, README, and at the top of the help for all relevant functions.
reprex is intended for interactive use and the clipboard has always been the user's primary means of providing input (a short piece of code) and the primary means of returning output (the rendered code). The package's use of the clipboard is prominently documented in package Title, README, and at the top of the help for all relevant functions.

As I have explained in previous email correspondence, it would substantially reduce the usability of reprex to require that the user explicitly request `clipboard = TRUE` in each call to `reprex()`. I have sought advice on any alternative and, in the meantime, have done as much as I can via documentation.

The failures at https://cran.r-project.org/web/checks/check_results_reprex.html pertain to v0.1.2 of reprex, authored and released by CRAN on 2018-01-26. I do not see them in the version I am submitting (see check platforms below). reprex has long been in ERROR on CRAN's macOS machines, since Pandoc appears to be unavailable. Pandoc is a declared SystemRequirement in DESCRIPTION and this has been true since v0.1.1 was released on 2017-01-13.

Notes from several previous attempts update reprex ----------------------------

No example shows the act of writing to or reading from a file in the user's file space. It is always to a file below the session temp directory.

reprex no longer accesses the clipboard on CRAN: not via examples, tests, or the vignette (which I believe may have been what launched xsel in the previous re-submission).
reprex no longer accesses the clipboard on CRAN: not via examples, tests, or the vignette (which I believe may have been what launched xsel in a previous re-submission).

The documentation for both reprex() and reprex_clean()/reprex_invert()/ reprex_rescue()) now states in the first sentence that the primary purpose of these functions is specifically to write to the user's clipboard. If a user does not want to use the clipboard features of reprex, then the user would use the rmarkdown or knitr package directly to render their code. I believe usage of reprex package and the reprex()/reprex_clean()/reprex_invert()/ reprex_rescue() functions implies that the user understands that reprex may read from or write to the clipboard.

Expand All @@ -18,10 +20,10 @@ I've also made sure reprex tests that exercise Pandoc don't run if Pandoc is not

## Test environments

* local OS X install, R 3.4.3
* local OS X install, R 3.4.3 and R 3.5.0
* Ubuntu 14.04.5 LTS (trusty) via travis-ci, R 3.1 through R-devel
* Windows Server 2012 R2 x64 (build 9600), R 3.5.0 via appveyor
* Windows, R Under development (unstable) (2018-02-01 r74194) via win-builder
* Windows, R 3.4.4, 3.5.0, Under development (unstable) (2018-06-20 r74924) via win-builder

## R CMD check results

Expand Down

0 comments on commit af513a4

Please sign in to comment.