Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tidyverse_quiet also quiet tidymodels startup messages? #326

Closed
juliasilge opened this issue Jul 30, 2020 · 2 comments · Fixed by #327
Closed

Make tidyverse_quiet also quiet tidymodels startup messages? #326

juliasilge opened this issue Jul 30, 2020 · 2 comments · Fixed by #327

Comments

@juliasilge
Copy link
Member

What would you think about the tidyverse_quiet option also setting tidymodels.quiet? I don't know that having a separate option makes a lot of sense, but folks who don't want their reprexes to be filled with tidyverse startup message probably don't want them to have tidymodels start up messages either.

Our current startup message looks something like this:

library(tidymodels)
#> ── Attaching packages ─────────────────────────────────────────────── tidymodels 0.1.1 ──
#> ✓ broom     0.7.0          ✓ recipes   0.1.13    
#> ✓ dials     0.0.8          ✓ rsample   0.0.7     
#> ✓ dplyr     1.0.0          ✓ tibble    3.0.3     
#> ✓ ggplot2   3.3.2          ✓ tidyr     1.1.0     
#> ✓ infer     0.5.3          ✓ tune      0.1.1.9000
#> ✓ modeldata 0.0.2          ✓ workflows 0.1.2     
#> ✓ parsnip   0.1.2.9000     ✓ yardstick 0.0.7     
#> ✓ purrr     0.3.4
#> ── Conflicts ────────────────────────────────────────────────── tidymodels_conflicts() ──
#> x purrr::discard() masks scales::discard()
#> x dplyr::filter()  masks stats::filter()
#> x dplyr::lag()     masks stats::lag()
#> x recipes::step()  masks stats::step()

Created on 2020-07-30 by the reprex package (v0.3.0.9001)

@jennybc
Copy link
Member

jennybc commented Jul 30, 2020

Hmm. It's hard to decide if it should get its own option. In terms of meaning what you say and saying what you mean, it seems like it should. But I also agree it seems like the user's wishes for the two would typically be the same. Maybe bring this up in slack and/or poll our team?

@juliasilge
Copy link
Member Author

We chatted and the plan is to extend the tidyverse_quiet option of reprex to also control the tidymodels option tidymodels.quiet. I'll submit a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants